ESCOMP / ESCOMP/CTSM

Balance checks not turned on for CLM-DART simulations

Open
#2,525 4 comments 0 reactions 0 assignees View on GitHub
bug usability
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

### Brief summary of bug

When running CLM-DART (multi-instance run w/ ``DATA_ASSIMILATION_LND=TRUE``) the ``DA_nstep`` variable within [BalanceCheckMod.F90](https://github.com/ESCOMP/CTSM/blob/10a2345967c78e527323f26421a44a75b6eb63ca/src/biogeophys/BalanceCheckMod.F90#L613) and [CNVegetationFacade.F90](https://github.com/ESCOMP/CTSM/blob/10a2345967c78e527323f26421a44a75b6eb63ca/src/biogeochem/CNVegetationFacade.F90#L1210) does not appear to get updated. This prevents the carbon, nitrogen, water and energy balance checks from being turned on after ``skip_steps`` is passed.

### General bug information

Version: release-cesm2.2.03

The bug prevents balance checks from being performed when DA is implemented and for all timesteps thereafter.

### Details of bug

See summary above. We have usually circumvented this issue by utilizing the ``is_first_restart_step`` variable
initialized within ``clm_time_manager.F90`` to indicate the first time step after DA. This approach is suboptimal, and
doesn't seem to leverage intent of code.

### Important details of your setup / configuration so we can reproduce the bug

Compset: 2000_DATM%GSWP3v1_CLM50%BGC-CROP_SICE_SOCN_MOSART_SGLC_SWAV
Resolution: f09_f09_mg17
Machine: Derecho
Compiler: Intel

For example of specific configuration details see:
case directory: /glade/work/bmraczka/cases/ctsm_cesm2.2.03/clm5_print_e5
run directory: /glade/derecho/scratch/bmraczka/ctsm_cesm2.2.03/clm5_print_e5/run

### Important output or errors that show the problem

No errors will be output, although it should trigger warning message:
``--WARNING-- skipping CN balance check for first timesteps after startup or data assimilation``

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.