Remove duplication between gen_mksurfdata_jobscript_multi and gen_mksurfdata_jobscript_single
Open
code health
enhancement
priority: low
test: mksurfdata
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 6d 6h
- Merged PRs (30d)
- 8
Description
This was brought up in #2290. gen_mksurfdata_jobscript_single has parts that are duplicated with gen_mksurfdata_jobscript_multi and hence changes have to go in two places. This was for example an issue in #2427 which means that extra testing needs to be done because of that duplication.
An improvement to the design would be to have gen_mksurfdata_jobscript_single as the base level script that is expanded on by gen_mksurfdata_jobscript_multi which then doesn't duplicate code, but only adds the additional functionality needed there.
This is something that we will do as a post-CTSM5.2 development.
Contributor guide
Assessment
This issue has not been assessed yet.