ESCOMP / ESCOMP/CTSM

Should we now allow constants in the FORTRAN code be all uppercase? And start making that change in the code?

Open
#2,426 2 comments 0 reactions 1 assignee Claimed by @adrifoster View on GitHub
code health
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

As discussed here:

https://github.com/ESCOMP/CTSM/pull/2401#discussion_r1514954169

There's a desire to use all uppercase for constants in the FORTRAN code. I do find this nicely readable. But, as discussed above we didn't allow it because ALL uppercase was reserved for CPP tokens. However, we almost don't have any CPP tokens in the code anymore. And haven't for at least a decade now? So maybe we could start allowing it?

And as a future cleanup after CESM3 do we move to making this change for all constants?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.