ESCOMP / ESCOMP/CTSM

Get init_interp working correctly with hillslope initial conditions files

Open
#1,806 3 comments 0 reactions 0 assignees View on GitHub
enhancement priority: low
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

I'm pretty sure that init_interp won't currently work correctly with initial conditions files from a hillslope run. (I'm also not positive it's working ideally for interpolation from a non-hillslope run to a hillslope run, but it seems likely that it's at least doing something reasonable in that situation.) One need – maybe the main one – is to label each column with appropriate metadata so that, in the interpolation, we can copy data from the source lowland column to the destination lowland column, etc. This can be done with discrete labels giving the type of each column and/or a continuous (real-valued) variable that lets us find the closest match. Currently, all vegetated columns are given the same type index and init_interp doesn't have a way to handle multiple columns in the vegetated landunit. (In contrast, for some other landunits, like crop and glacier, we have mechanisms to ensure that the appropriate source column from a landunit is associated with a given destination column.)

A good first-order check of whether this is working correctly is whether interpolating an initial conditions file onto an identical configuration will result in a replica of the original initial conditions file (this is what the LII test checks). Currently I believe this would not be the case. But eventually - at least if hillslope becomes default - we also want this to be doing something reasonable when interpolating from one resolution / hillslope configuration to another.

@swensosc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.