ESCOMP / ESCOMP/CTSM

Use secsphr in UrbBuildTempOleson2015Mod.F90

Open
#1,653 0 comments 0 reactions 0 assignees View on GitHub
code health
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

In bringing in PR #1535 I noticed this issue, but didn't have a chance to fix it. So a simple bit-for-bit fix is to change instances of secsphr in UrbBuildTempOleson2015Mod.F90 to 3600.

Looking at the code the constant .10_r8 , should also become a local parameter for energy imbalance threshold. vent_ach could also be local to UrbBuildTempOleson2015Mod rather than in clm_varcon. 1.e-06_r8 could be a view factor error threshold parameter. Array indices could also be setup as parameters rather than hardcoded integer constants as well.

It's also possible that instead of sending both is_simple_buildtemp and is_prog_buildtemp that the logic could be simplified, since they both can neither be both true nor can both be false. One must be true and one must be false as configured now.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.