ESCOMP / ESCOMP/CTSM

Move run_has_transient_landcover function into a fire-specific module

Open
#1,560 0 comments 0 reactions 0 assignees View on GitHub
b4b code health good first issue
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

The function run_has_transient_landcover is defined here:

https://github.com/ESCOMP/CTSM/blob/2a88e90c40da6f87cb92d0efbcbec3a63d037d6c/src/dyn_subgrid/dynSubgridControlMod.F90#L350
However, as noted here:

https://github.com/ESCOMP/CTSM/pull/1546#discussion_r753724575

there are subtleties about which aspects of transient landcover should and should not be included in this function. As I noted in the above comment:

> I was initially concerned that you added urban to this conditional, but lake is not included. However, after some analysis of how this function is used, I think this is correct: this is just used by the fire code, which really wants to know whether there are any potential deforestation fires. Forests being replaced by urban could be linked with deforestation fires; forests being replaced by lakes / reservoirs seem very unlikely to be linked with deforestation fires.

Probably what we should do is to move this function into the fire code, and make it fire-specific, since otherwise it isn't obvious why this should include some transitions but not others.

As noted in https://github.com/ESCOMP/CTSM/issues/52 there are some broader issues with the mix of human-induced and natural landcover transitions, but those bigger issues would probably be a pain to fix, so for now I think it is sufficient to move this run_has_transient_landcover function into the fire code with comments saying that this just includes potentially human-induced aspects of landcover change.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.