ESCOMP / ESCOMP/CTSM

Move accumulation data from the base type to the module where it's actually used

Open
#1,453 0 comments 0 reactions 0 assignees View on GitHub
code health priority: low
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

When we need to have accumulation data from accumulMod for a module typically that's been done in the base Type of where the data naturally best goes. This is even done when that accumulation data is only used in one module. A better way to do this would be to move the accumulation data to the module where it's actually used, so it can be local to ONLY that module.

An example of this is t_a5min_patch which is handled in TemperatureType.F90, but it's actually only used in CNPhenologyMod.F90. If it was moved to CNPhenologyMod it could be local to only that module. This also means that the accumulation would only happen when BGC is on as opposed to all the time as it is now. It makes CNPhenology the expert in how to handle this instead of spreading it out into another module that doesn't actually do anything with it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.