ESCOMP / ESCOMP/CTSM

Get rid of set_* arguments in hist_addfld calls

Open
#1,350 0 comments 0 reactions 0 assignees View on GitHub
code health
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

Although this is still open to discussion (I'll open a discussion issue shortly), I propose getting rid of the set_* arguments in hist_addfld calls. In cases where we have set_*=spval, we're going to use landunit_mask (#1347). In places where we have set_*=0, my preference is to do this setting in initCold instead: I find it unintuitive to set fields to certain values in the hist_addfld call, and I'm also concerned that doing the setting in the hist_addfld call can be misleading because this could be overridden later in the code (i.e., it is not guaranteed that the field will remain at the value set via the set_* argument).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.