Use of floating point flag onset_thresh is confusing in CNPhenologyMod
Open
code health
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 6d 6h
- Merged PRs (30d)
- 8
Description
The subroutine CNSeasonDecidPhenology in CNPhenologyMod uses a floating point variable onset_thresh for purposes that would be more clear if it were a logical variable. I noticed this in the review of #990, but wanted to make it a bit-for-bit refactoring at a later point because simulations are already being done with the current logic.
This is in ctsm5.1.dev034.
Contributor guide
Assessment
This issue has not been assessed yet.