ESCOMP / ESCOMP/CTSM

instantiate FATES only on active columns

Open
#1,305 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

Fates instantiates (ie allocates and does fates stuff) on ALL soil columns. See here:

https://github.com/ESCOMP/CTSM/blob/master/src/utils/clmfates_interfaceMod.F90#L523-L543

However, the soil column filter upon which we do soil physics is limited to active columns, see here: https://github.com/ESCOMP/CTSM/blob/master/src/main/filterMod.F90#L368-L380

Also, the hydrology filter, here: https://github.com/ESCOMP/CTSM/blob/master/src/main/filterMod.F90#L398-L407

So, no point in running fates if it is not on a column with hydrology and biogeochemistry.

The need arose to get this fixed because of coupling issues with soil biogeochemistry in E3SM, which will be applied at some point for CTSM in the future. See here: https://github.com/E3SM-Project/E3SM/pull/4157

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.