ESCOMP / ESCOMP/CTSM

Some build-namelist refactoring for FATES/CN fire data

Open
#1,272 0 comments 0 reactions 1 assignee Claimed by @ekluzek View on GitHub
b4b code health good first issue
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

I noticed this in #1264 and addressed some of it there, but didn't finish. There's a bunch of unneeded duplication of fire data variables for FATES and use_cn versions. There's no reason for this duplication. I mostly addressed this for lightning data. Since we want FATES and BGC to use the same datasets it would be best if they aren't duplicated.

The checks for lightning settings should be refactored a bit so that it recognizes when fire data needs to be included and when it doesn't. light_res==none is the flag that lightning data isn't needed. But, it should check the settings of both fire_method and fates_spitfire_mode to see if that's consistent.

Also as part of this I'd like to add more namelist tests for the new FATES modes that currently aren't being tested in the build-namelist unit tester.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.