ESCOMP / ESCOMP/CTSM

c2l_scale_type not specified for many history fields

Open
#1 3 comments 0 reactions 1 assignee Claimed by @adrifoster View on GitHub
bug priority: low science
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

**Bill Sacks < sacks@ucar.edu > - 2011-08-22 13:49:04 -0600**
**Bugzilla Id:** [1397](http://bugz.cgd.ucar.edu/show_bug.cgi?id=1397)
**Bugzilla CC:** oleson@ucar.edu, rfisher@ucar.edu, sacks@ucar.edu,

Many history fields do not have a c2l_scale_type parameter (in histFldsMod), but it seems they should. For example, there is a set of water flux variables, starting with QFLX_RAIN_GRND and ending with QFLX_DEW_SNOW, most of which do not have a c2l_scale_type. From talking with Keith Oleson, it seems that at least some and maybe all of these should have c2l_scale_type='urbanf', by analogy with similar fluxes that do have a c2l_scale_type specified.

From talking with Keith Oleson: it sounds like most fluxes should have c2l_scale_type='urbanf', but this isn't necessarily always true. So this will require more investigation to determine the appropriate scale type for each history field.

Most (all?) of the fields that do not have a c2l_scale_type are ones that were added after the urban model came in - for example, fields that were added when the CN code came in. So my guess is that whoever added these fields didn't realize that a c2l_scale_type was required.

After these fields are fixed, perhaps scale_type_c2l should be made a required argument to hist_addfld1d and hist_addfld2d to prevent this problem from arising again in the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.