ESCOMP / ESCOMP/CMEPS

CMEPS does NOT add files to cpl.input_data_list for existence checking

Open
#526 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Fortran
Stars
35
Forks
106
Avg merge
6d 5h
Merged PRs (30d)
4

Description

CMEPS always has empty cpl.input_data_list files because the buildnml doesn't send the right list of groups to it's write. None of the variables in the groups sent are files and so the list is always empty. The groups sent are: papi_inparm, prof_inparm and debug_inparm. The groups that *should* be sent are the various *_attributes groups.

See this code difference here, for what I think it should change to:

``` python
diff --git a/cime_config/buildnml b/cime_config/buildnml
index 7ffc28f8..d71842ba 100755
--- a/cime_config/buildnml
+++ b/cime_config/buildnml
@@ -320,7 +320,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files):
# Write namelist file drv_in and initial input dataset list.
# --------------------------------
namelist_file = os.path.join(confdir, "drv_in")
- drv_namelist_groups = ["papi_inparm", "prof_inparm", "debug_inparm"]
+ drv_namelist_groups = ["DRIVER_attributes", "MED_attributes", "ALLCOMP_attributes", "ROF_attributes", "WAV_attributes"]
nmlgen.write_output_file(
namelist_file, data_list_path=data_list_path, groups=drv_namelist_groups
)
```

Fixing this would be helpful to catch when a CMEPS driver file isn't available on a machine, as well as make it easier to download it.

Technically there are currently no files in the DRIVER_attributes group, but for completeness in case anything is added it seems like it should be in the list. Also more groups could be added that don't currently have files like LND_attributes for example.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.