ESCOMP / ESCOMP/CISM-wrapper

Time manager (glc_time_management.F90) needs some additional changes to support longer timesteps and leap years

Open
#6 5 comments 0 reactions 0 assignees View on GitHub
low priority
Dominant language
Fortran
Stars
4
Forks
18
PR merge metrics
No merged PRs in 30d

Description

**Bill Sacks < sacks > - 2011-11-18 11:45:16 -0700**
**Bugzilla Id:** [1433](http://bugz.cgd.ucar.edu/show_bug.cgi?id=1433)
**Bugzilla CC:** erik, lipscomb, mvertens,

I am modifying the time manager to allow longer timesteps (multi-month, annual or multi-year). However, I am not fixing everything right now.

Things I have found that need to be fixed in the future:

- determination of newhour in subroutine time_manager: I believe that this line:

if (ihour /= ihour_last) newhour = .true.

will not work for time steps that are multiples of a day

Also, I have not checked all of the code completely to be sure that things will work correctly for longer timesteps. In particular, I have not checked the code that determines stopping conditions: does any of this stop-related code implicitly assume timesteps shorter than about 1 month? Similarly for the time_to_do and time_to_start functions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.