ESCOMP / ESCOMP/CDEPS

Inconsistent regex in (at least) datm config_component

Open
#401 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
32
Forks
68
Avg merge
5d 13h
Merged PRs (30d)
2

Description

In some of the xml entries there is no `^` prefixed to simyear in attribute conditions. A user makes a typo in the compset (f.e. they had a bash variable `compset_name="I1850Clm60Sp"` and than changed its value to a compset longname to f.e. get rid of prognostic ROF: `compset_name="1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_SGLC_SWAV"` and made a typo, f.e. left `I` in front of the symyear: `compset_name="I1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_SGLC_SWAV"`. What will happen is variables like `DATM_PRESAERO` will get `deafult_value` value, since `^` is present in the attributes there:
https://github.com/ESCOMP/CDEPS/blob/3f7f22d0426ccc1428a1ebfd4357caf90009132a/datm/cime_config/config_component.xml#L79-L103

While things like `DATM_YR_START` will pick up the correct conditioned value:

https://github.com/ESCOMP/CDEPS/blob/3f7f22d0426ccc1428a1ebfd4357caf90009132a/datm/cime_config/config_component.xml#L266-L317

In general it should be handled in probably cime by validating the compset's symyear. Which means, that if a user does not check xml variables, he(she) will get correct DATM years but will run with a wrong `DATM_PRESAERO`, `_
PRESNDEP`,`CO2_TSERIES` etc.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.