ESCOMP / ESCOMP/CAM

Bugzilla 1974 - Cannot use flag_xyfill option with subcolumns

Open
#3 0 comments 0 reactions 1 assignee Claimed by @gold2718 View on GitHub
bug
Dominant language
No language data
Stars
91
Forks
183
Avg merge
6d 2m
Merged PRs (30d)
9

Description

Opened : Steve Goldhaber 2014-05-15 14:19:33 MDT
If you call addfld with flag_xyfill = .true. for a field with subcolumns, calls to outfld will crash if any column has nsubcol < psubcols.
Proposed action is to call endrun at addfld time to avoid crashing later in the run.

Comment 1: Steve Goldhaber 2014-05-15 15:54:53 MDT
To fix this, we have to first move some code:

In addfld (cam_history), move this code:

!
! Whether to apply xy fillvalue: default is false
!
if (present(flag_xyfill)) then
listentry%field%flag_xyfill = flag_xyfill
else
listentry%field%flag_xyfill = .false.
end if

below the if block that begins with:
if(present(mdimnames)) then

Then add logic after the line:
listentry%field%flag_xyfill = flag_xyfill

to the tune of:
if (listentry%field%is_subcol .and. flag_xyfill) then
call endrun('addfld: flag_xyfill not supported for subcolumn fields')
end if

Comment 2: Brian Eaton 2014-05-16 07:58:53 MDT
It looks like subcol_unpack deals with adding a fillvalue to the subcols from nsubcol+1 to psubcols. What is the actual problem?

Comment 3: Cheryl Craig 2016-05-04 14:06:29 MDT
Bug 1975 has been marked as a duplicate of this bug.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.