ESCOMP / ESCOMP/CAM

Discussion on git commit requirements

Open
#25 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
91
Forks
183
Avg merge
6d 2m
Merged PRs (30d)
9

Description

From email by @gold2718

I still do not understand the logic of mashing together unrelated commits. The GitHub workflow is smoother and issues are easier to track (and debug) when made separately.
Using this issue and #20 as an example, say for the sake of argument that issue #20 introduced a change (AQP11 to AQPCONST) which is incompatible with my current work. Because there is no separate commit with issue #22 alone, I cannot easily use that while avoiding the #20 change as well.
Merging #20 as a separate PR with a couple of simple tests (already made by @nusbaume) would make no difference in the testing required to merge #20 and make a tag. On the other hand, it makes needed changes available more quickly.
If anyone still disagrees, please add some compelling arguments here.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the discussion in this issue alongside issues #20 and #22, especially the examples about combining commits and the existing tests mentioned for #20. The issue does not identify files, an entry point, or a concrete completion condition, so the desired outcome must be agreed before implementation can begin.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.