ESCOMP / ESCOMP/CAM-SIMA

test_registry.py: repeated numbers

Open Beginner friendly
#552 0 comments 0 reactions 0 assignees View on GitHub
code clean-up
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### Issue Type

Code Clean-up

### Issue Description

During the review of #507, @cacraigucar originally wrote:

> Perhaps to keep these in sync in the future, we could have a variable that is set to the 4 on both these lines. But, I see this pattern is used throughout this file, so perhaps not worth changing.

This refers to the assertion error messages here
https://github.com/ESCOMP/CAM-SIMA/blob/e62a76359e49736eb236681ec83befdeced1ffa2/test/unit/python/test_registry.py#L108-L109

https://github.com/ESCOMP/CAM-SIMA/blob/e62a76359e49736eb236681ec83befdeced1ffa2/test/unit/python/test_registry.py#L136-L137

which duplicate what the code states. It would be annoying to write these as parameters, but this also causes drift if not.

### Will this change answers?

No

### Will you be implementing this yourself?

Any Software Engineer can do this

Contributor guide

No contributing guide indexed for this repository

Research direction

Open test/unit/python/test_registry.py and inspect the assertion error messages around lines 108-109 and 136-137, then review the surrounding repeated-number pattern. Run the relevant registry tests first; done means the duplicated values stay synchronized without changing the test answers.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.