ESCOMP / ESCOMP/CAM-SIMA

*_PDC physics-dynamics coupling diagnostics wrong on CSLAM (pgN) grids: missing dp_fvm weighting

Open Beginner friendly
#550 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### What happened?

Analogous issue to https://github.com/ESCOMP/CAM/issues/1669

The fix in CAM-SIMA is the same in line `prim_advance_mod.F90:435` replace it with
```fortran
ftmp_fvm(i,j,k,q,ie) = (tmp-v1)*fvm(ie)%dp_fvm(i,j,k) !Only used for diagnostics!
```

### What are the steps to reproduce the bug?

FHIST_C4 ne16pg3: WV_PDC values are <= 0 with magnitude <= 2e-26, consistent with mixing-ratio (kg/kg) units rather than kg/m2.

### What CAM-SIMA hash were you using?

sima0_20_002

### What machine were you running CAM-SIMA on?

CGD machine (e.g. izumi)

### What compiler were you using?

GNU

### Path to a case directory, if applicable

_No response_

### Will you be addressing this bug yourself?

Any Software Engineer can do this

### Extra info

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at prim_advance_mod.F90:435 and compare the CAM-SIMA fix with CAM issue #1669. Reproduce the FHIST_C4 ne16pg3 case on the stated GNU setup, then verify that WV_PDC diagnostics on CSLAM pgN grids have the expected kg/m2 magnitude rather than mixing-ratio units.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.