ESCOMP / ESCOMP/CAM-SIMA

Create script to check for integer constants that are meant to be reals

Open
#548 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### Issue Type

Other (please describe below)

### Issue Description

Numbers like `2_r8` are interpreted as `integer(r8)`, rather than `real(r8)`. Since Fortitude does not flag these, we need a way to identify numbers that are intended to be reals but are being interpreted as integers (which could lead to accidentally doing integer arithmetic)

The new script should:
1. Identify potentially erroneous numbers in committed code
2. Run as part of the Fortran linting CI.

### Will this change answers?

No

### Will you be implementing this yourself?

Any Software Engineer can do this

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the existing Fortitude configuration and Fortran linting CI workflow, then inspect how checks are currently defined and run. Define the cases the script should identify in committed code and integrate it into that linting run; done means the script detects the problematic integer constants and CI executes it.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.