ZM snapshot needs update after ZM science code updated (energy fix)
- Dominant language
- No language data
- Stars
- 9
- Forks
- 22
- Avg merge
- 8d 5h
- Merged PRs (30d)
- 4
Description
### What happened?
ZM test will fail physics data check comparison (although it does not crash) since the underlying science code changed compared to the snapshot
### What are the steps to reproduce the bug?
Run CAM-SIMA with atmos_phys >= atmos_phys0_21_003
### What CAM-SIMA hash were you using?
0ec863eb45ee8e82018a37a3aaf7f903afb2e533
### What machine were you running CAM-SIMA on?
CISL machine (e.g. cheyenne)
### What compiler were you using?
GNU
### Path to a case directory, if applicable
_No response_
### Will you be addressing this bug yourself?
Any Software Engineer can do this
### Extra info
Note that to get the ZM snapshot this part of the code in CAM `physics_types.F90` needs to be removed (I remember @cacraigucar mentioning that this needed to be done when the original ZM snapshot was made)
```fortran
! now test for mixing ratios which are too small
! don't call qneg3 for number concentration variables
if (m /= ixnumice .and. m /= ixnumliq .and. &
m /= ixnumrain .and. m /= ixnumsnow ) then
call qneg3(trim(ptend%name), state%lchnk, ncol, state%psetcols, pver, m, m, qmin(m:m), state%q(:,1:pver,m:m))
else
do k = ptend%top_level, ptend%bot_level
! checks for number concentration
state%q(:ncol,k,m) = max(1.e-12_r8,state%q(:ncol,k,m))
state%q(:ncol,k,m) = min(1.e10_r8,state%q(:ncol,k,m))
end do
end if
```
I would add this as a note, too, on the top of `user_nl_cam` for the ZM testmod, so future SEs can remember this.
When the UW shallow convection scheme is merged, a new scheme `clamp_number_concentrations` can be used instead of modding CAM itself. But whatever we do it needs to be documented.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.