ESCOMP / ESCOMP/CAM-SIMA

Set logical before printing thermodynamically active species in air_composition

Open
#303 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### What happened?

Right now, we're printing out `Thermodynamic active species` information for every constituent, regardless of whether it's actually thermodynamically active

`src/data/air_composition.F90`: line ~434

### What are the steps to reproduce the bug?

Add a new constituent via the metadata (`advected = true`) that is not in the case select for thermodynamically active species in air_composition.F90.

Then see that that constituent is listed in the atm.log under "Thermodynamic active species "

### What CAM-SIMA hash were you using?

c99c034a

### What machine were you running CAM-SIMA on?

CGD machine (e.g. izumi)

### What compiler were you using?

GNU

### Path to a case directory, if applicable

_No response_

### Will you be addressing this bug yourself?

Any Software Engineer can do this

### Extra info

What we need is a logical that defaults to .false. and is set to true only if one of the case selects is entered. And then the writing to iulog should only happen for iterations when the logical is .true.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.