ESCOMP / ESCOMP/CAM-SIMA

Allocate hist_coords to max dimensions rather than arbitrary limit

Open
#302 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### What is the feature/what would you like to discuss?

In `src/history/cam_history_support.F90`, we have:
```
integer, parameter :: maxmdims = 25 ! arbitrary limit
type(hist_coord_t), public :: hist_coords(maxmdims)
```
Instead, as pointed out by @nusbaume in https://github.com/ESCOMP/CAM-SIMA/pull/274, we should determine the biggest number of dimensions that were needed (based on the user_nl_cam history variables configured), and have the maxmdims value set to that (with hist_coords then an allocatable variable that is allocated to that size)

### Is there anyone in particular you want to be part of this conversation?

_No response_

### Will this change (regression test) answers?

No

### Will you be implementing this enhancement yourself?

Any Software Engineer can do this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.