ESCOMP / ESCOMP/CAM-SIMA

Over-allocating active species arrays in air_composition.F90

Open
#213 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
9
Forks
22
Avg merge
8d 5h
Merged PRs (30d)
4

Description

### Issue Type

Code Clean-up

### Issue Description

In air_composition_init (air_composition.F90), we are allocating the thermodynamic_active_species_* arrays to num_advected, which, in the long term, may be far larger than it needs to be.

The code in CAM was allocating these to dry_air_species + water_air_species, which were determined by the NL. The NL entries have been removed, so we will need a new way to allocate these arrays in a more efficient manner.

### Will this change answers?

None

### Will you be implementing this yourself?

Any Software Engineer can do this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.