EOSIO / EOSIO/eos-token-distribution

ability to reuse EOS key and MetaMask REJECT exception

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
191
Forks
141
PR merge metrics
No merged PRs in 30d

Description

I figure it's being done this way to avoid people mis-entering their public/private EOS Token Sale Claim Keys (and possibly due to the implementation as well), but it would be nice if we could reuse and add to a particular address instead of having a separate Claim Key for each spend (or at least for multiple spends in the same day).

Also, "Your EOS" on the UI is a really nice addition as well (pretty sure it wasn't there yesterday, though if it was I hadn't noticed it).

Finally, at least for MetaMask users, it seems to pop up with a 0 ETH transaction, and always asks for 20 gas price (max transaction fee = 7 USD) which can be lowered to 2 (max = 71 cents USD). When I REJECT it, the UI pops up this exception:

>Error: Error: MetaMask Tx Signature: User denied transaction signature.
at TransactionController. (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:4350:25)
at TransactionController.g (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42698:16)
at TransactionController.EventEmitter.emit (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42614:17)
at TransactionController._setTxStatus (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1555:14)
at TransactionController.setTxStatusRejected (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1444:12)
at TransactionController.cancelTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1313:12)
at Proto.apply (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33833:13)
at Proto.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33809:19)
at dnode.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34088:21)
at dnode.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34076:22)
at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5

I have a feeling that may be outside the scope of the contract's UI to capture the exception since it's coming from a chrome plugin, but figured I'd at least bring it up anyway.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.