EMsoft-org / EMsoft-org/EMsoftOO

NLPAR with ROI

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
8
Forks
21
PR merge metrics
No merged PRs in 30d

Description

If NLPAR is used with an ROI set, then the array indexing logic is broken. More specifically, out of bounds values are queried in multiple places. For specific input values, I was able to generate the errors in the following lines:
- negative index for `exptIQ` in [Line 680](https://github.com/EMsoft-org/EMsoftOO/blob/5d9bd108a034365767e655b5a6817981ac1a27be/Source/EMsoftOOLib/mod_NLPAR.f90#L680)
- negative record number for the temporary file, `itmpexpt` in [Line 729](https://github.com/EMsoft-org/EMsoftOO/blob/5d9bd108a034365767e655b5a6817981ac1a27be/Source/EMsoftOOLib/mod_NLPAR.f90#L729)
- negative `pixcnt` in [Line 828](https://github.com/EMsoft-org/EMsoftOO/blob/5d9bd108a034365767e655b5a6817981ac1a27be/Source/EMsoftOOLib/mod_vendors.f90#L828)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.