EMsoft-org / EMsoft-org/EMsoft

EMsoftData_DIR not set after git pull

Open
#171 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
84
Forks
113
PR merge metrics
No merged PRs in 30d

Description

I seem to have run into a bug when building EMsoft 5.0.4 (develop branch) when making the Tests. Source/Test/CMakeLists.txtm Lines 88-100. First conditional checks if the EMsoftData_DIR location exists, and if so, sets it:

if(EXISTS "${EMSOFT_PARENT}/EMsoftData")
set(EMsoftData_DIR ${EMSOFT_PARENT}/EMsoftData)

If it doesn't exists, it then does a git pull to get it. However, it then never sets the EMsoftData_DIR variable. If run on persistent storage, it seems running the setup twice will work as the first time pulls it then errors out further along, and second time it will find the directory and keep going. However, when trying to build an apptainer container, this doesn't work as the files get purged with every run. a manual git pull of the repo fixed it so it exists before the setup scripts are run. However, it might be better to just run the same "set(EMsoftData_DIR ${EMSOFT_PARENT}/EMsoftData)" after the "ExternalProject_Add" call completes.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.