EMsoft-org / EMsoft-org/EMSphInx

binned detector height incorrectly rounded to 94 (from 96.3) for 5x5 binning

Open
#6 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
13
Forks
27
Avg merge
1d 42m
Merged PRs (30d)
2

Description

Using the EMSPHINX wizard in version 0.2 to index a scan taken with 5x5 binning causes the binned detector width (taken from the up2 file) to be rounded up from 93.6 pix to 94 pix. This value is unable to be changed (the box is grayed out in the software), so the rounded (incorrect) binned detector width propagates throughout the other calculation steps so that, for instance, the unbinned detector width is calculated to be 470 (94 * 5) when in fact the real value should be 468 (93.6 * 5). This ultimately results in incorrect pattern center values, which causes the final re-indexed scan png to be entirely black despite the fact that the raw confidence indices (when the scan was originally taken) had an average value of 0.5. Fiddling with the pattern center values will get SOME color to show up in the output png, but it's very noisy and still full of black spots.

Some screenshots:
screenshot1
screenshot2
screenshot3
screenshot4
screenshot5
![image](https://user-images.githubusercontent.com/35269133/73901884-ed0b3000-4848-11ea-94e4-46426155c224.png)

Thanks in advance for the help!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.