EIPStackGroup / EIPStackGroup/OpENer

OpENer/source/src/cip /cipcommon.c link:1407

Open
#488 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
857
Forks
314
Avg merge
18d 2h
Merged PRs (30d)
1

Description

This does not seem to match the latest standards of Ethernet/IP
in "switch(*message_runner)"

Your processing logic is like this:
If "Logical Format" is 01 (LOGICAL_SEGMENT_FORMAT_SIXTEEN_BIT)
Will execute "message_runner += 2;" and then obtain the information
That is, skip the current Logical Segment (one byte) and then skip an additional byte to obtain the data.

But in the latest Ethernert/IP standard (Vol1_3.33 page:1442), whether to skip an extra byte depends on the "Logical Segment
Type ",if"Logical Segment Type " is 111(Extended Logical), there is an extra byte to record "Extended Logical Type", and "Logical
Format" doesn't matter.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.