EIPStackGroup / EIPStackGroup/OpENer

Rework NotifyMessageRouter to cope better with services

Open
#146 0 comments 0 reactions 1 assignee Claimed by @MartinMelikMerkumians View on GitHub
bug enhancement help wanted
Dominant language
C
Stars
857
Forks
314
Avg merge
18d 2h
Merged PRs (30d)
1

Description

The current implementation of NotifyMessageRouter takes a certain structure of EPath as given in order to give a correct result or error code.

As seen in the issues #125 #138 #139 #140 #143 this assumption is invalid for Get/Set/Insert/Remove Member services, and perhaps other services too. A better way would be to first check if the service is supported by the CIP object and which service is requested, and then parse and create the correct structure for the service to be handled

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.