DNR rules do not ignore subresource requests to localhost
Closed
bug
MV3
- Dominant language
- JavaScript
- Stars
- 3.8k
- Forks
- 435
- Avg merge
- 49m
- Merged PRs (30d)
- 1
Description
Should fix MV3 request modification to match MV2 request modification and MV2/MV3 reporting, and ignore resource requests to localhost.
https://github.com/EFForg/privacybadger/blob/a1634a6e7cc42303bfbb2a34b2e539d5a3d1c008/src/lib/basedomain.js#L153-L191
Following up on https://github.com/EFForg/privacybadger/issues/817#issuecomment-5516594122
Related to #3231
Contributor guide
Research direction
Start in src/lib/basedomain.js around lines 153-191 and compare the MV2 and MV3 request-modification and reporting paths. Review issue #817's referenced comment and related issue #3231 for context. Done means subresource requests to localhost are ignored and MV3 behavior matches the stated MV2 request-modification and reporting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100