Also compute hashes with Windows newlines
- Dominant language
- No language data
- Stars
- 50
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Currently, [the list of known-good policies](https://github.com/EFForg/dnt-policy/blob/master/dnt-policies.json) is computed using literal sha1 hashes of the files in the repo. If people save and copy the files with certain tools on Windows, they may wind up with [different newlines](https://en.wikipedia.org/wiki/Newline#Representations). We should probably at least handle the CR+LF case correctly.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the code that computes the hashes and the use of dnt-policies.json as the known-good list. Trace how file newlines are read, then verify that policy files using LF and CRLF produce accepted hashes. The payload does not name a test, so add or run the repository's relevant hash checks if available.
Written by the indexing model from the issue text.
Assessment
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100