EDCD / EDCD/EDMarketConnector

Revisit EDDN Journal vs cAPI Priorities

Open
#2,156 0 comments 0 reactions 1 assignee Claimed by @Rixxan View on GitHub
enhancement
Dominant language
Python
Stars
1.3k
Forks
182
Avg merge
1m
Merged PRs (30d)
1

Description

**Describe the enhancement**

Currently, for some EDDN endpoints (particularly commodity), latches exist that would prevent the journal file from being read, and relying instead on cAPI responses alone.

From the Discord:
`Given it's the default, most EDMC users will have "Automatically update on docking" active, which means they'll always do a CAPI pull. This means this.commodities will be pre-populated with the data if the player opens the Market screen and causes market.json to be read. If the station market hasn't changed then that check will prevent a market.json-based EDDN message from also being sent.`

This is particularly evident in the `export_journal_commodities` function, which includes some data missing from the cAPI-based response.

This behavior should be revisited to determine if it is how we truly want to do things.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.