EDCD / EDCD/EDMarketConnector

EDDN: Journal outfitting schema - check FDevIDs/outfitting.csv SKUs

Open
#1,797 0 comments 0 reactions 0 assignees View on GitHub
bug EDDN unconfirmed
Dominant language
Python
Stars
1.3k
Forks
182
Avg merge
1m
Merged PRs (30d)
1

Description

1. The [EDDN docs](https://github.com/EDCD/EDDN/blob/live/schemas/outfitting-README.md) say "Items that have a non-null "sku" property, unless it's "ELITE_HORIZONS_V_PLANETARY_LANDINGS" (i.e. PowerPlay and tech broker items)." for elisions.
2. But the current plugins/eddn.py code will only apply that check for CAPI-sourced data, because SKUs aren't cited in Outfitting.json

So, we should probably cross-reference the module name/id with FDevIDs/outfitting.csv to see if *that* has a SKU cited that means the module should be filtered out in `export_journal_outfitting()`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.