EDCD / EDCD/EDMarketConnector

Investigate disabling 'Update' button unless Journal-docked.

Open
#1,225 8 comments 0 reactions 0 assignees View on GitHub
CAPI enhancement
Dominant language
Python
Stars
1.3k
Forks
182
Avg merge
1m
Merged PRs (30d)
1

Description

Users are pressing 'Update' because they expect it to, e.g. send new data about them to Inara. It will not, nor EDSM. The most it would do is send updated (if different from currently held data) for market, shipyard and outfitting out to EDDN and other plugins.

We also have other uses pressing Update when not docked and experiencing spurious status messages: #1208 & #1018

There are some caveats:

- [ ] The `File` > `Status` information about all your owned ships only comes from the `/profile` endpoint. So would be unavailable if not docked during the session. We can probably just address #1188 to take care of this.
- [ ] We might want a user to pull CAPI data for some diagnosis. We could leave `File` > `Save Raw Data...` able to work anyway for this purpose. But note #1168 should be addressed as well, allowing for pulling fresh data if none is yet cached.
- [ ] This absolutely requires #1188 as well. Yes, I repeat myself, it's important.
- [ ] Make **absolutely sure** that any and all functionality that relies on CAPI data continues to function properly.
- [ ] Is EDMC.py still working absolutely as it did before ?

Contributor guide

Open the contributing guide

Research direction

Start in EDMC.py by tracing the Update action and how its enabled state relates to being Journal-docked. Review the caveats around File > Status, File > Save Raw Data..., #1188, #1168, #1208, and #1018. Done means Update is unavailable when not docked while Save Raw Data and all CAPI-dependent functionality continue to work correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.