EDCD / EDCD/EDDN

Commodity schema - "renamed" missing

Open
#233 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
347
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Typo in attribute "renamed".
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L98

Missing "renamed" from "FID" ?
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L16

Missing "renamed" from "build".
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L23

Missing "renamed" from "Horizons"
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L66

Missing "renamed" from "Odyssey"
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L70

Missing "renamed" from "StarSystem"
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L45

eg:
"stationName": "Orbital Construction Site: Edwards Legacy"
"systemName": "HIP 27510"

"renamed" should be "StationName"
https://github.com/EDCD/EDDN/blob/72905efab353a08f92b5ed836f0a2d3a272fb538/schemas/commodity-v3.0.json#L51

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.