EC-CUBE / EC-CUBE/ec-cube2

SC_Helper_Payment 全メソッド static とする

Open
#1,427 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
PHP
Stars
92
Forks
97
Avg merge
4d 2h
Merged PRs (30d)
9

Description

どれもインスタンス化する必要性なさそう。

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the SC_Helper_Payment class and read every method together with its callers to determine whether any instance state is used. Check the existing tests or payment-related entry points before changing the class. Done means the helper methods are static where appropriate, callers still work, and the payment-related test coverage passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
payments
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.