E4S-Project / E4S-Project/testsuite

how to distinguish spack tests in validation_tests directory

Open
#47 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Fortran
Stars
21
Forks
33
Avg merge
3m
Merged PRs (30d)
1

Description

@wspear

The validation_tests directory contains a lot of tests and it is not clear which ones invoke spack test and which one are not. It would be better to either remove all test that invoke spack test from this repo, if there is a need to keep them around i would suggest put them in a separate directory so its easier to keep track of them.

One option would be to have two top-level directories validation_tests and spack_tests. I suspect there will be translation as test migrates from validation_tests --> spack_tests when a package supports spack test. It is something to consider, i am trying to distinguish which tests should run from E4S Testsuite and which ones run from spack test and i dont want to write redundant tests from two different test suites.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the tests under validation_tests and identifying which invoke spack test. Compare those tests with the tests run by the E4S Testsuite, then resolve whether they should be removed or separated into a distinct location. Done means the repository has a clear, agreed way to distinguish the two test groups.

Written by the indexing model from the issue text.

Assessment

Domain
testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.