E3SM-Project / E3SM-Project/scream

HommeDynamics: move timestamp update of PG fields out of fv_phys_dyn_to_fv_phys, and into initialize_impl

Open
#2,265 0 comments 0 reactions 1 assignee Claimed by @bartgol View on GitHub
code cleanup dynamics priority:low
Dominant language
No language data
Stars
79
Forks
54
PR merge metrics
No merged PRs in 30d

Description

As noted by @ambrad in #2251 , the fix implemented in that PR introduced a redundant update of output fields, since `fv_phys_dyn_to_fv_phys` is called not only at init time, but also during the postprocess call at every time step. Although the double timestamp update is safe, it is redundant (and redundant code can generate confusion/bugs down the road), so it's best to move it out of that routine, and inside the calling function at init time.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.