E3SM-Project / E3SM-Project/scream
ENERGY, keep open: mass, energy diagnostics
- Dominant language
- No language data
- Stars
- 79
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
This is to discuss the current impl of mass and energy diagnostics with possible changes.
I see a couple of issues with the current implementation:
1) it is column-based, not globally integrated
2) it requires implementations in each package's interface level
In no way this is a good approach to do this, but debug statements in branch https://github.com/E3SM-Project/scream/compare/oksanaguba/scream/mass-debug use FM("Physics") fields to access necessary fields and compute diagnostics, indep. of whether the package has such implementations. I think it also will allow to use field_sum() to get global integrals. The current impl. can be modified to be used in global sums, but I do not see why we would want to do it this way.
Instead, I would propose to re-design mass/energy checks to move them out of packages and into AD, with using FM fields (i can see that if FM is not used directly, a package could potentially "hide" its leaks).
A minor point is that i would "shrink" the current mass/energy diagnostics message, too.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.