E3SM-Project / E3SM-Project/scream

Better test column ops

Open
#1,338 0 comments 0 reactions 0 assignees View on GitHub
priority:medium testing
Dominant language
No language data
Stars
79
Forks
54
PR merge metrics
No merged PRs in 30d

Description

As #1337 suggests, our column ops are not sufficiently tested. In particular, it's not enough to test packed/non-packed versions, but, for the packed case, we also need to test both `NUM_INT_PACKS==NUM_MID_PACKS` as well as `NUM_INT_PACKS>NUM_MID_PACKS`. Given pack size restrictions, if num_mid_levels is a power of 2, then we always fall in the second case (provided pack size is <= num_mid_levels). That's the only scenario we were testing (and it's the one interesting for scream, which will operate at 128 levels). But some tests run with less levels (e.g., 72 levels for our homme-relatd tests), and for some pack sizes (e.g., the default, 16) can fall in the first scenario, which in some cases can trigger a different impl in ColumnOps.

Hence, we need to test something like `num_levels=n*SCREAM_PACK_SIZE` as well as `num_levels=n*SCREAM_PACK_SIZE + SCREAM_PACK_SIZE/2`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.