E3SM-Project / E3SM-Project/scorpio

Allow users to set NetCDF_[C|Fortran]_PATHS

Open
#459 0 comments 0 reactions 1 assignee Claimed by @dqwu View on GitHub
Dominant language
C++
Stars
22
Forks
20
Avg merge
12d 19m
Merged PRs (30d)
1

Description

Currently users are recommended to use NetCDF_PATH or NetCDF_[C|Fortran]\_PATH to set the paths to the NetCDF libraries. Although NetCDF_[C|Fortran]\_PATHS is recognized by the find_package_component() cmake function (in cmake/LibFind.cmake), that is used to find the NetCDF library/package, there are assumptions in the code that its never set by the user (the user invoking cmake).

In FindNetCDF.cmake NetCDF_[C|Fortran]\_PATHS is initialized (in certain conditions). Instead of initializing NetCDF_[C|Fortran]\_PATHS directly a temporary variable could be initialized and appended to NetCDF_[C|Fortran]\_PATHS ensuring that the paths set by the user is not overridden.

Also see Issue #456

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.