E3SM-Project / E3SM-Project/codesign-kernels
Array too small?
Open
- Dominant language
- Fortran
- Stars
- 4
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/E3SM-Project/codesign-kernels/blob/e994a3b8de9793d1f2b170d5730e90645f63aa7d/mmf-mpdata-tracer/advect_scalar2D_pushncols_openacc.F90#L126
`real(rp) :: www (nslices,-1:nxp2,1,nz)` where `nxp2 is nx + 2` while `nxp3 is nx + 3`.
`if (k == 1) www(sl,i,j,nz) = 0.` where `do i=-1,nxp3`.
IMO the www array is too small, it will fail randomly, likely it will not fail when compiled with gfortran, but this is only matter of luck, and well written programs should not rely on luck.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.