E3SM-Project / E3SM-Project/EKAT

Testing both single and double precision together can hide issues

Open
#446 0 comments 1 reaction 2 assignees Claimed by @bartgol View on GitHub
enhancement testing
Dominant language
C++
Stars
22
Forks
12
PR merge metrics
No merged PRs in 30d

Description

As a follow up to PR #445 , we should change our CACTS configuration to test single precision _separately_ from double. The reason is that if `EKAT_TEST_DOUBLE_PRECISION` is defined, our unit tests use `Real=double`, regardless of anything else. In order to force a test where `Real=float`, we need to have only one between `EKAT_TEST_DOUBLE_PRECISION` and `EKAT_TEST_SINGLE_PRECISION` defined.

My reccomendation would be to test both sp and dp in debug builds, and only dp in release builds (which matches what we already do in eamxx anyways).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.