E3SM-Project / E3SM-Project/E3SM

Incorrect N/P uptake and phosphatase activity

Open
#571 0 comments 0 reactions 1 assignee Claimed by @qzhu-lbl View on GitHub
bug ELM
Dominant language
Fortran
Stars
440
Forks
481
Avg merge
4d 6h
Merged PRs (30d)
36

Description

model crash due to nimbalance/pimbalance errors for BGC composet ECA mode
1. CNAllocationMod.F90
- incorrectly allocate retranslocaiton N/P flux
- under MIC mode, plant N uptake flux is incorrect
2. CNPhenologyMod.F90
- litterfall N P fluxes can be non-negative values
3. PDynamicsMod.F90 (also affect CTC mode)
- did not subtract biochemical P mineralization flux from SOP pool
4. PhosphorusFluxType.F90
- typo in adsorption/desorption hist_addfld1d
5. PhotosynthesisMod.F90
- leaf nitrogen content / leaf phosphorus content could be physically unreasonable high/low

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.