E3SM-Project / E3SM-Project/E3SM
CLUBB does not conserve energy
@vlarson is already working on this.
Since Aug 6, 2021.
- Dominant language
- Fortran
- Stars
- 441
- Forks
- 481
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 33
Description
There is a limiter in physics_update that fixes negative vapor produced by clubb. The limiter changes energy, but there is no energy fix after the limiter. This leads to energy leaks from clubb.
I assume that the limiter also contributes to very infrequent MG2 energy errors and maybe ZM errors.
One could try to put a local, active only in a column, energy fixer in physics_update. Overall, I would think limiters should be a part of the physics package, not an interface, but that is an unlikely change. Maybe, placing a mass-conserving limiter in clubb_intr before brute-force energy conservation is computed would fix it. However, at least 2 more packages, ZM and MG2, might need the same change before the limiter can be removed from physics_update.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.