E3SM-Project / E3SM-Project/E3SM
the "forest_fert_exp" option does not work properly for nitrogen or phosphorus
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 441
- Forks
- 481
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 33
Description
Apparently, the following line
call get_curr_date(kyr, kmo, kda, mcsec)
was deleted inadvertently in NitrogenStateUpdate1Mod.F90 and PhosphorusStateUpdate1Mod.F90 during one of the update.
This will cause error or model crash when the code is configured to do fertilization experiments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by opening NitrogenStateUpdate1Mod.F90 and PhosphorusStateUpdate1Mod.F90 and inspect the fertilization-experiment paths around the state update logic. Confirm how get_curr_date(kyr, kmo, kda, mcsec) is used there. Done means the forest_fert_exp configuration no longer errors or crashes during nitrogen or phosphorus fertilization experiments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100