E3SM-Project / E3SM-Project/E3SM

Missing use statements in ELM,MOSART not triggering build errors

Open
#3,532 0 comments 0 reactions 0 assignees View on GitHub
ELM MOSART
Dominant language
Fortran
Stars
441
Forks
481
Avg merge
4d 7h
Merged PRs (30d)
33

Description

While building an E3SM case with a newer version of CIME, some build errors were triggered that were NOT being picked up by current master but, I think, should be. They all involve a failure to use a variable from shr_kind_mod.

In mosart/src/cpl/rof_comp_mct.F90:
`character(len=SHR_KIND_CL) :: caseid`
SHR_KIND_CL is not defined. Should come in through use of shr_kind_mod.

In clm/src/biogeochem/SatellitePhenologyMod.F90
`character(SHR_KIND_CXX) :: fldList ! field string`
SHR_KINDCXX is not defined. Should come in through use of shr_kind_mod.

In clm/src/cpl/lnd_comp_mct.F90:
`character(len=SHR_KIND_CL) :: caseid`
SHR_KIND_CL is not defined. Should come in through use of shr_kind_mod.

This is on compy using intel.
To reproduce, check out master, rename "cime" to "cime.old" and then clone ESMCI cime in its place. cd in to cime and check out Jim's branch at https://github.com/ESMCI/cime/pull/3457. Case to try and build is --compset ICLM45 --res f19_f19

Contributor guide

Open the contributing guide

Research direction

Start with mosart/src/cpl/rof_comp_mct.F90, clm/src/biogeochem/SatellitePhenologyMod.F90, and clm/src/cpl/lnd_comp_mct.F90, checking how shr_kind_mod is used around the reported declarations. Reproduce the ICLM45 f19_f19 build with the ESMCI CIME branch from PR 3457; done means the missing shr_kind_mod variables are resolved and the build catches no corresponding errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.