DynamoRIO / DynamoRIO/dynamorio
Missing cases in switch statements in drx-scattergather-aarch64.cpp
Open
OpSys-AArch64
- Dominant language
- C
- Stars
- 3.2k
- Forks
- 629
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
Clang warns about these missing cases. The `switch` statements are at:
https://github.com/DynamoRIO/dynamorio/blob/eb5bd836f7dd882b42a0c751999fde526218969c/suite/tests/client-interface/drx-scattergather-aarch64.cpp#L2442
https://github.com/DynamoRIO/dynamorio/blob/eb5bd836f7dd882b42a0c751999fde526218969c/suite/tests/client-interface/drx-scattergather-aarch64.cpp#L2446
When I added `default: assert(false);` some tests failed so perhaps falling through is correct, but someone should check before adding `default: break;`.
I think @jackgallagher-arm is the expert on this file.
Contributor guide
Assessment
This issue has not been assessed yet.