DynamoRIO / DynamoRIO/dynamorio

should config param env var inserted to propagate to child precede global env var?

Open
#755 0 comments 0 reactions 0 assignees View on GitHub
Migrated OpSys-Windows Priority-Medium
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

_From [bruen...@google.com](https://code.google.com/u/109494838902877177630/) on April 25, 2012 16:53:52_

**\* TODO why isn't child using same logdir as parent on xp64?

inserted into env vars:
0:000> du 009f1c24
00000000`009f1c24 "DYNAMORIO_LOGDIR=F:\derek\build_"
00000000`009f1c64 "suite\build_debug-internal-64\lo"
00000000`009f1ca4 "gs"

but this one from my global settings comes first:
DYNAMORIO_LOGDIR=E:/derek/dr/logs

0:000> s -u 9e0000 9fffff DYNAMORIO_LOGDIR
00000000`009f079a 0044 0059 004e 0041 004d 004f 0052 0049 D.Y.N.A.M.O.R.I.
00000000`009f1c24 0044 0059 004e 0041 004d 004f 0052 0049 D.Y.N.A.M.O.R.I.
0:000> du 009f079a
00000000`009f079a "DYNAMORIO_LOGDIR=E:/derek/dr/log"
00000000`009f07da "s"

I propagate config params to child proc on windows via appending env vars
rather than creating .1config file, and a global env var will be earlier on
env var list and so today it wins. child propagation shouldn't be thought
of as like a .1config file, since we want it trumped by a named config
file, so it should have relatively low priority: but maybe it should be
higher than global env? but that makes it impossible to use global env as
default when using drrun. would have to use drconfig to get env var value
in parent.

_Original issue: http://code.google.com/p/dynamorio/issues/detail?id=755_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.